You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
###Expected behaviour
unique ID value of a release stored in DB table release_unique
###Actual behaviour
Same value is stored for many releases
###Steps to reproduce the behaviour
Simply run Tmux with Fix Release Names enabled and PostProcess Additional: All
Cause:
[v0.8.22.0]
nzedb\ReleaseExtra.php line 48:
$uniqueId = (int)$general->get('unique_id')->getShortName();
Method getShortName produces a number value that exceeds PHP Max integer length. Typecasting to int produces an integer overflow resulting in the same integer across releases.
IMHO the value can be stored in the DB as-is (Not typecasted to int).
Fix:
nzedb\ReleaseExtra.php line 48:
$uniqueId = $general->get('unique_id')->getShortName();
also:
if (isset($uniqueId) && strlen($uniqueId) > 1)
provides for better validity checking of shortName in the xml.
This fix seems to produce a unique ID per release allowing individual matching of releases.
The text was updated successfully, but these errors were encountered:
SenTzu01
changed the title
Many releases matched to incorrect searchname
Many releases get incorrectly renamed (Also see Issue #2609)
May 3, 2023
###Expected behaviour
unique ID value of a release stored in DB table release_unique
###Actual behaviour
Same value is stored for many releases
###Steps to reproduce the behaviour
Simply run Tmux with Fix Release Names enabled and PostProcess Additional: All
Cause:
[v0.8.22.0]
nzedb\ReleaseExtra.php line 48:
$uniqueId = (int)$general->get('unique_id')->getShortName();
Method getShortName produces a number value that exceeds PHP Max integer length. Typecasting to int produces an integer overflow resulting in the same integer across releases.
IMHO the value can be stored in the DB as-is (Not typecasted to int).
Fix:
nzedb\ReleaseExtra.php line 48:
$uniqueId = $general->get('unique_id')->getShortName();
also:
if (isset($uniqueId) && strlen($uniqueId) > 1)
provides for better validity checking of shortName in the xml.
This fix seems to produce a unique ID per release allowing individual matching of releases.
The text was updated successfully, but these errors were encountered: