[Request] make read_register() protected for possible derivatives

[2bndy5]

I've been revisiting the pyRF24 repo to re-write the python wrappers with pybind11 (nRF24/pyRF24#3)

I'm using inheritance to enhance the python wrappers' API in a more pythonic way. By inheriting from RF24, I expect to use read_register() to provide new functionality that would be otherwise unnecessary for low-memory platforms (ie getters for the driver's attributes like is_powered or is_dyn_pl_enabled). However, currently, read_register() is a private function. I remember seeing a similar discussion in an old issue about mz-fuzzy's RF24Remote project (#63).

Pybind11 boasts automatic downcasting, so passing a derived object of RF24 to classes like RF24Network and RF24Mesh should be no problem. However, if this presents a problem I could have the python wrappers' source manually downcast derived objects of RF24.

ps - all functionality in the current python wrappers will be still present, but the casing for member names will use PEP8 standards (CRCLength will be crc_length)

[TMRh20]

This would be fine by me

…

On Aug 10, 2021, at 1:56 AM, Brendan ***@***.***> wrote:  I've been revisiting the pyRF24 repo to re-write the python wrappers with pybind11 (nRF24/pyRF24#3) I'm using inheritance to enhance the python wrappers' API in a more pythonic way. By inheriting from RF24, I expect to use read_register() to provide new functionality that would be otherwise unnecessary for low-memory platforms (ie getters for the driver's attributes like is_powered or is_dyn_pl_enabled). However, currently, read_register() is a private function. I remember seeing a similar discussion in an old issue about mz-fuzzy's RF24Remote project (#63). Pybind11 boasts automatic downcasting, so passing a derived object of RF24 to classes like RF24Network and RF24Mesh should be no problem. However, if this presents a problem I could have the python wrappers' source manually downcast derived objects of RF24. ps - all functionality in the current python wrappers will be still present, but the casing for member names will use PEP8 standards (CRCLength will be crc_length) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.