Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts don't support mirrors with https protocol in url #44

Open
liback opened this issue May 1, 2020 · 0 comments
Open

Scripts don't support mirrors with https protocol in url #44

liback opened this issue May 1, 2020 · 0 comments
Labels

Comments

@liback
Copy link
Contributor

liback commented May 1, 2020

When selecting what mirror to choose the common pattern is like below, which won't match https. The installer automatically chooses another mirror when selecting a https one.

mirror=$(grep "^$number=[fhtp]\{3,4\}://[^ ]*$" nquake.ini | cut -d "=" -f2)

Should be as follows (s added to allowed chars and 5 instead of 4 max chars for protocol part)

mirror=$(grep "^$number=[fhtps]\{3,5\}://[^ ]*$" nquake.ini | cut -d "=" -f2)

Workaround is to define them as http as they will redirect to https anyway (can fix the script of course but for existing installations it's not really practical)

@liback liback added the bug label May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant