Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio/x-lds magic rule is too broad #114

Open
atsampson opened this issue May 5, 2024 · 1 comment
Open

audio/x-lds magic rule is too broad #114

atsampson opened this issue May 5, 2024 · 1 comment

Comments

@atsampson
Copy link

atsampson commented May 5, 2024

I've just been trying to work out why gdk-pixbuf's test suite had mysteriously stopped working, and it turned out to be OCP!

The magic rule in desktop/opencubicplayer.xml for audio/x-lds matches any file that starts with byte \x00 or \x01. That means that an awful lot of files in other formats will be spuriously identified by anything using the XDG MIME database as audio/x-lds. For example, several of the images in gdk-pixbuf's test suite happen to start with a 0 or 1 byte - and some image formats nearly always do.

(Edit: the Adlib formats look to be similar - I've just had another image file identified as audio/x-xad-hyp.)

Unless there's a more specific signature for that file format, I suspect it'd be better to just drop that magic rule...

@mywave82
Copy link
Owner

mywave82 commented May 5, 2024

I agree that some of the magic matches should be removed, and others probably have their priority lowered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants