Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-restricted-disable rule isn't working with require-description rule #78

Open
eppisapiafsl opened this issue Jun 16, 2023 · 2 comments

Comments

@eppisapiafsl
Copy link

Hi

There is an edge case in the no-restricted-disable rule when the require-description is enable

The no-restricted-disable doesn't catch the disable line when there is a break line in the description

When the description is single line, it work as expected

// eslint-disable-next-line eslint-comments/no-restricted-disable -- Catch the error
// eslint-disable-next-line react-hooks/exhaustive-deps  -- Needs to be called only on mounted component

Description with multiline

/* eslint-disable-next-line react-hooks/exhaustive-deps  -- 
  This is not reported by the no-restricted-disable rule */
@MichaelDeBoey
Copy link

Hi @eppisapiafsl!

Since this repo is unmaintained, you might want to re-open this issue in the @eslint-community fork https://github.com/eslint-community/eslint-plugin-eslint-comments

For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org

@eppisapiafsl
Copy link
Author

Thanks @MichaelDeBoey , will post in the community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants