Trailing spaces break get_inner_columns_with_types

[bryzgaloff]

Example of a wrong behaviour

get_inner_columns_with_types function (from clickhouse_driver.columns.util module) returns a wrong value when input spec argument has a trailing space character. For example:

• get_inner_columns_with_types('test String') (no trailing space) returns [('test', 'String')] which is correct.
• but get_inner_columns_with_types('test String ') (with a trailing space) returns [('test String', '')] (no type is detected) which is incorrect.

Real life example for trailing whitespace characters:

ch_client.execute(
    external_tables=[{
        'name': 'ext',
        'structure': [('nested_field', '''Nested(
            test String
        )''')],  # here trailing whitespaces appear
        …

Possible solution

Maybe a simple spec.rstrip() should help. At least it helps when calling get_inner_columns_with_types('test String '.rstrip()) :)

As a part of a fix, I would also recommend replace elif x == ' ': with elif x.isspace()::

clickhouse-driver/clickhouse_driver/columns/util.py

Line 57 in ce712b5

elif x == ' ':

Versions

clickhouse_driver version is 0.2.6