-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor enhancements #92
Comments
Your attentiveness is admirable! Some of the content of this repository may seem less appropriate with Vue's update, and some of your suggestions are fine. My focus is not on Vue for the time being, if you can, PR welcome! |
I got it wrong :p |
As I was reading through the source code, I've listed some minor issues which may improve the project:
mapValidationResponse
does not handle403
error<template #default>
for suspenseuseArticles
composable:6.1. In
fetchArticles
function, sincearticleType
can only have one value, it's better to useif-else
rather than onlyif
to skip other checks.6.2
getArticlesMeta
function is acting like a composable. So maybe it's better to rename it touseArticlesMeta
reactive()
. So it may be better to change current generic usage.AppLink
component,useAttrs
andv-bind="attrs"
can be removed because of Fallthrough AttributesI would like to help fix these issues if they are valid to you. :D
The text was updated successfully, but these errors were encountered: