Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open mxl file with zip version 45 #22854

Open
ChrisAm1224 opened this issue May 16, 2024 · 4 comments
Open

Can't open mxl file with zip version 45 #22854

ChrisAm1224 opened this issue May 16, 2024 · 4 comments
Assignees
Labels
MusicXML needs info More information is required before action can be taken

Comments

@ChrisAm1224
Copy link

ChrisAm1224 commented May 16, 2024

Issue type

Opening/saving issue

Bug description

Can't open attached mxl file because the zip version is 45

Steps to reproduce

Attempt to open file
Composition1.SHY_.mxl.zip
(note I had to rename it to zip because of the webform). MuseScore thinks it's a bad format:
image
Click Yes:
image

Screenshots/Screen recordings

No response

MuseScore Version

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore Studio version (64-bit): 4.3.0-241231433, revision: github-musescore-musescore-5f36e74

Regression

No.

Operating system

Windows 11

Additional context

No response

@bkunda bkunda added the needs info More information is required before action can be taken label May 17, 2024
@ChrisAm1224
Copy link
Author

ChrisAm1224 commented May 19, 2024

suspicion is that QZipReader doesn't support newer zip formats (zip64). libzip might be a better choice.

@cbjeukendrup
Copy link
Contributor

We don't use QZipReader itself; our zip implementation is in https://github.com/musescore/MuseScore/blob/master/src/framework/global/serialization/internal/zipcontainer.cpp. However, it does look like that code is basically copied from Qt (compare with https://codebrowser.dev/qt5/qtbase/src/gui/text/qzip.cpp.html).

Switching to a different ZIP solution may not be a bad idea. We suspect that this miserable mystery is also caused by errors in the ZIP-related code: #16339

@ChrisAm1224
Copy link
Author

libzip (https://libzip.org/, https://github.com/nih-at/libzip/) is based on the original zlib library (https://github.com/madler/zlib) and seems fairly stable and mature.

@irwir
Copy link

irwir commented May 19, 2024

Example application miniunz from zlib 1.3.1 properly handled this archive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MusicXML needs info More information is required before action can be taken
Projects
None yet
Development

No branches or pull requests

5 participants