-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't open mxl file with zip version 45 #22854
Comments
suspicion is that QZipReader doesn't support newer zip formats (zip64). libzip might be a better choice. |
We don't use QZipReader itself; our zip implementation is in https://github.com/musescore/MuseScore/blob/master/src/framework/global/serialization/internal/zipcontainer.cpp. However, it does look like that code is basically copied from Qt (compare with https://codebrowser.dev/qt5/qtbase/src/gui/text/qzip.cpp.html). Switching to a different ZIP solution may not be a bad idea. We suspect that this miserable mystery is also caused by errors in the ZIP-related code: #16339 |
libzip (https://libzip.org/, https://github.com/nih-at/libzip/) is based on the original zlib library (https://github.com/madler/zlib) and seems fairly stable and mature. |
Example application |
Issue type
Opening/saving issue
Bug description
Can't open attached mxl file because the zip version is 45
Steps to reproduce
Attempt to open file
Composition1.SHY_.mxl.zip
(note I had to rename it to zip because of the webform). MuseScore thinks it's a bad format:
Click Yes:
Screenshots/Screen recordings
No response
MuseScore Version
OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore Studio version (64-bit): 4.3.0-241231433, revision: github-musescore-musescore-5f36e74
Regression
No.
Operating system
Windows 11
Additional context
No response
The text was updated successfully, but these errors were encountered: