-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trill color not respected after opening score #20856
Comments
Allow me to try and help with this one even though it's been only a couple of days that I've been looking at MU's code. Here is my 2 cents:
|
Fix musescore#20856: Fixed ignored color on trill after opening score
Hi @krasko78 - the fix in the linked commit looks good to me! It would be great if you could make a PR so we can merge this. Here's a link to the developer handbook with some instructions if needed. Thanks! |
@miiizen Could you do it for me instead? I have never created a pull request to master and I believe it will take me time to find out how to do it properly, accept the necessary agreements, etc. Plus I have been having some busy days lately. It is really a small change. Thanks. |
I'll do it. If you tell me your email address, I'll credit you for it too |
[email protected] |
Thanks, all done |
Jojo, someone else is going to approve the PR, correct? |
Yes |
Issue type
Engraving bug (incorrect score rendering)
Bug description
Open the attached score. In m.29-33 the left hand has a trill with the wavy line. Upon opening the score, this is displayed in black although if you select the trill and go to Appearance in the Properties panel, you will see that the color should be #c80064 rather than black. Changing the color correctly updates on the screen, but if the score is closed and reopened, the trill is black again and the previously chosen color is still there, just not respected. Interestingly, the trill in m.19-21 does honor its color (the same for both trills in this score).
Bach - BWV 775 - Two-part Invention No.4 in D minor (copy).zip
Steps to reproduce
See the description above.
Screenshots/Screen recordings
MuseScore Version
4.2
Regression
I don't know
Operating system
Windows 10
Additional context
No response
The text was updated successfully, but these errors were encountered: