Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper ISMINE_WITNESS behaviour #198

Open
mjmacleod opened this issue Mar 10, 2020 · 0 comments
Open

Proper ISMINE_WITNESS behaviour #198

mjmacleod opened this issue Mar 10, 2020 · 0 comments

Comments

@mjmacleod
Copy link
Member

When we have only the witness key for a witness address and not the spending key, the codebase should behave differently.

The first part of this is already handled the various 'ismine' functions return ISMINE_WITNESS; however presently the rest of the codebase doesn't know how to deal with this and treats it as ISMINE_SPEND (aside from various UI components that treat things differntly at an account level, and a few RPC commands that know better.)

The rest of the codebase should be fixed to handle this correctly.

See: 3c1381b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant