Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lox to GitHub Linguist? #1144

Open
HallofFamer opened this issue Oct 31, 2023 · 2 comments
Open

Add lox to GitHub Linguist? #1144

HallofFamer opened this issue Oct 31, 2023 · 2 comments

Comments

@HallofFamer
Copy link

HallofFamer commented Oct 31, 2023

It seems that it is possible for us to add Lox as a language at Linguist. We will need to submit a PR to linguist (https://github.com/github-linguist/linguist) and complete the checklist:

  1. The extension of the new language is used in hundreds of repositories on GitHub.com.
  2. I have included a real-world usage sample for all extensions added in this PR.
  3. I have included a syntax highlighting grammar.
  4. I have added a color.
  5. I have updated the heuristics to distinguish my language from others using the same extension

I think we do have hundreds of repos that include Lox script files, also a syntax highlighting grammar plugin is available on vscode (https://marketplace.visualstudio.com/items?itemName=dberezin.lox-language). I am not sure if there’s a good example of real world application written in Lox, but maybe someone can share the findings (perhaps the Loxlox interpreters count?)

Note: I have found at least 1 Lox derived language on GitHub linguist already, so I don’t see a reason why Lox shouldn’t be on the list too.

@munificent What is your thought about this? We will not make such a request without your approval.

@munificent
Copy link
Owner

I would love it!

@HallofFamer
Copy link
Author

Thx @munificent, I have forked linguist and created a branch ‘add-lox’, will work on it in a few days and hopefully will have a pull request ready after I complete the proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants