Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clox throws an error on the string_equality benchmark #1093

Open
ajeetdsouza opened this issue Oct 24, 2022 · 0 comments
Open

clox throws an error on the string_equality benchmark #1093

ajeetdsouza opened this issue Oct 24, 2022 · 0 comments

Comments

@ajeetdsouza
Copy link

ajeetdsouza commented Oct 24, 2022

To reproduce:

make clox
./clox test/benchmark/string_equality.lox

Output:

[line 32] Error at 'a4': Too many constants in one chunk.
[line 32] Error at 'a7': Too many constants in one chunk.
[line 32] Error at 'a5': Too many constants in one chunk.
[line 32] Error at 'a7': Too many constants in one chunk.
[line 32] Error at 'a6': Too many constants in one chunk.
[line 32] Error at 'a7': Too many constants in one chunk.
[line 32] Error at 'a7': Too many constants in one chunk.
[line 32] Error at 'a7': Too many constants in one chunk.
[line 32] Error at 'a8': Too many constants in one chunk.
...

The same benchmark works correctly with jlox because it doesn't enforce limits on constants, but it would be great if the benchmark was updated to something that could run on both, so that they could be compared more easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant