Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent signatures for Environment.getAt/assingAt #1086

Open
pekkaklarck opened this issue Aug 26, 2022 · 0 comments
Open

Inconsistent signatures for Environment.getAt/assingAt #1086

pekkaklarck opened this issue Aug 26, 2022 · 0 comments

Comments

@pekkaklarck
Copy link

Signatures at Environment.java are:

Object getAt(int distance, String name)
void assignAt(int distance, Token name, Object value)

Using either String or Token as the type of name would fix the inconsistency. Using Token would also be consistency with get and assign which actually need a Token. Both getAt and assignAt would be fine also with String.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant