New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overrides for locations #386

Open

goncalo-rodrigues opened this issue Jul 28, 2022 · 0 comments

Assignees

Labels

feature help wanted

Member

goncalo-rodrigues commented Jul 28, 2022

Multy has a mapping for regions

multy/resources/common/cloud_provider.go

Line 16 in 4f57fcf

var LOCATION = map[commonpb.Location]map[commonpb.CloudProvider]string{

. In some cases, users might want a different region that is not covered by us.

To do to complete this issue:

Add override field to https://github.com/multycloud/multy/blob/main/api/proto/commonpb/common.proto#L79
Use override if specified in https://github.com/multycloud/multy/blob/main/resources/resource_with_id.go#L39 (and check for any other places where it might be accessed directly)
Add tests - probably something simple like similar to this https://github.com/multycloud/multy/tree/main/test/_configs/virtual_network/virtual_network or also some unit tests

goncalo-rodrigues added help wanted feature labels

goncalo-rodrigues self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment