Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this moot for functions whose output already includes these extra params? #72

Open
cottsak opened this issue Feb 27, 2017 · 3 comments

Comments

@cottsak
Copy link

cottsak commented Feb 27, 2017

Like bcrypt for example where the output already includes the work factor:

$2a$10$...
@jbenet
Copy link
Member

jbenet commented Feb 27, 2017

you could do it, just to be consistent. but you dont get much value if you're only storing bcrypt hashes

@cottsak
Copy link
Author

cottsak commented Feb 27, 2017

@jbenet Could do what? Implement bcrypt in multihash?

@ericdmoore
Copy link

TLDR:

I find lots of utility in the "to be consistent" argument.. If this is as simple as making a pull request against the multicodec table - please let me know, I will do so, and we can close this issue.

Background

If a project that is looking to adopt multihash as "standard for the project", which one might want to do if for no other reason than to have a system that accommodates different hash scheme - and can, at some later date migrate to a "more secure" hash - let alone for all the reasons described in the readme.md

To adopt this a the "standard way we hash" - it would be nice if bcrypt was available in the multicodec table perhaps where some standard bcrypt workfactors were coupled with the alogirthm - to add entries like bcrypt11, bcrypt14

( NOTE: I just made those up - please take those as potentially terrible examples to use in practice - but a reasonable illustration of pairing a work factor and algorithm name.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants