Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] codemods require certain version of nodejs otherwise fails with "Unexpected token ." #42110

Open
RyanEwen opened this issue May 3, 2024 · 2 comments
Assignees
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material support: docs-feedback Feedback from documentation page v5.x migration

Comments

@RyanEwen
Copy link

RyanEwen commented May 3, 2024

Related page

https://mui.com/material-ui/migration/migration-v4/#run-codemods

Kind of issue

Missing information

Issue description

I've spent the last hour trying to run codemods but getting Unexpected token ..

Eventually through trial and error I tried running older codemods and one of them told me that I need at least nodejs v12 (I was on v10). Sure enough after updating (I went to v20) the latest codemods get past the error.

Context

Migrating from mui 4 to 5

Search keywords: codemod unexpected token

@RyanEwen RyanEwen added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels May 3, 2024
@zannager zannager added docs Improvements or additions to the documentation v5.x migration labels May 3, 2024
@danilo-leal danilo-leal changed the title [docs] codemods require certain version of nodejs otherwise fails with "Unexpected token ." [material-ui][docs] codemods require certain version of nodejs otherwise fails with "Unexpected token ." May 7, 2024
@danilo-leal danilo-leal added the package: material-ui Specific to @mui/material label May 7, 2024
@mnajdova
Copy link
Member

mnajdova commented May 8, 2024

Thanks for the report. We have a section on supported browser and node version: https://mui.com/material-ui/migration/migration-v4/#supported-browsers-and-node-versions. Do you think we should move this to another section to make it clearer?

@mnajdova mnajdova removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 8, 2024
@RyanEwen
Copy link
Author

RyanEwen commented May 8, 2024

Somehow I missed that section when doing my migration. That's on me, I guess. It could be command line tools checked for this themselves when executed, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material support: docs-feedback Feedback from documentation page v5.x migration
Projects
None yet
Development

No branches or pull requests

4 participants