Skip to content
This repository has been archived by the owner on Jun 22, 2022. It is now read-only.

Mojibar for Windows? #14

Open
hiya-tiger opened this issue Aug 2, 2015 · 12 comments
Open

Mojibar for Windows? #14

hiya-tiger opened this issue Aug 2, 2015 · 12 comments

Comments

@hiya-tiger
Copy link

please?

@junosuarez
Copy link

upstream issue: max-mapper/menubar#46

@skiant
Copy link

skiant commented Aug 5, 2015

@hiya-tiger In case you didn't know you can already use Mojibar on windows by following the instructions in the "build" section of the readme : 

$ git clone https://github.com/muan/mojibar.git
$ cd mojibar
$ npm install
$ npm run app

You can also build an executable file from source : 

$ npm install -g electron-packager
$ electron-packager . Mojibar --platform=win32 --arch=x64 --version=0.30.0

Be aware of Windows limitations regarding emojis : http://caniemoji.com/windows/

@muan would you be ok with a PR to add a windows build in your pipeline?

@muan
Copy link
Owner

muan commented Aug 5, 2015

@skiant I plan to do that one day, but not w/ the current state of the app. As you linked to, there are changes to how emoji is displayed that needs to happen to support #10, and there will also need to be some layout changes. I don't have the bandwidth recently to do them though.

@egoist
Copy link

egoist commented Sep 17, 2015

temporarily you can use my fork https://github.com/egoist/mojibar

@patricknelson
Copy link
Contributor

For the record, 🎉 on @jsdnxx's comment since it's working fine for me now.

@egoist What was the critical change in your repo that caused the emoji to look that way, or, was that just due to the age of the app? Currently mine look like this (with a few missing emoji, probably new):

missing emoji s on win10

I'd say for better Windows compatibility, all we really need at this point is:

  • Polyfill to at least render (in-app) emoji's which aren't currently visible in the electron window (e.g. 🤔, while 😂 is supported without a placeholder). Or maybe use https://github.com/twitter/twemoji to render emoji uniformly whilst still retaining the standard Unicode in clipboard to be rendered normally wherever it gets pasted.
  • Windows equivalent for command key. I'd suggest continuance of the ctrl + shift combination as a drop-in replacement combined with , and q to open references and quit (correspondingly).
  • Personally. I might like to suggest also adding other user-friendly additions (e.g. in Windows it's common to be able to right-click the tray icon and select Quit from the context menu, or configure preferences here too).

Then I think we can incorporate the win32 build into releases moving forward once that's resolved. I could probably help a bit with this.

patricknelson added a commit to patricknelson/mojibar that referenced this issue Feb 18, 2017
… compatibility. Also adding title to hint user about keywords and copied. Added yarn since it's hella fast 😺
patricknelson added a commit to patricknelson/mojibar that referenced this issue Feb 18, 2017
…orrected systray transparency (on Win it can be dark) and added ability to center window on when loading.
@patricknelson
Copy link
Contributor

patricknelson commented Feb 18, 2017

Ok, got it working 🎉. See PR #86. This is what it looks like right now on my Win10 machine:

win10 demo

I've performed the following:

  • Replaced all icons with twitter emoji: https://github.com/twitter/twemoji
  • On windows, using ctrl + shift in place of command only for the preferences window (,) and quitting (q) and using Windows version of DevTools keyboard shortcut (Control+Shift+I).
  • On Win10, the system tray background can be dark, so removed transparency in the center of the icon (using white).
  • Added yarn.lock lock file, 'cause: shit's fast, yo! 🐱
  • New: Tooltips providing keyword hints. Now you know What keywords to use moving forward if you want to find other emojis (or exactly what portion of what you typed triggered a particular emoji).
  • New: Ability to customize window position. I really like it in the center, not all the way in the corner. The default is still topRight, however!

Here is a demo before/after for the icon (you'll see why I changed it):

Before:
icon before

After:
icon after

@patricknelson
Copy link
Contributor

p.s. I think it could be optimized to run more quickly (probably slower after this edit) by using classes to toggle display CSS instead of constantly re-parsing, see this line: https://github.com/muan/mojibar/pull/86/files#diff-1784aeec40c934a63010a661c2001055R164

patricknelson added a commit to patricknelson/mojibar that referenced this issue Feb 18, 2017
patricknelson added a commit to patricknelson/mojibar that referenced this issue Feb 18, 2017
patricknelson added a commit to patricknelson/mojibar that referenced this issue Feb 18, 2017
… of rendering, which is separate and only reduces based on search result.
patricknelson added a commit to patricknelson/mojibar that referenced this issue Feb 18, 2017
patricknelson added a commit to patricknelson/mojibar that referenced this issue Feb 21, 2017
patricknelson added a commit to patricknelson/mojibar that referenced this issue Feb 21, 2017
patricknelson added a commit to patricknelson/mojibar that referenced this issue Mar 13, 2017
@yzhang-gh
Copy link

yzhang-gh commented Jun 14, 2017

It seems that emoji keyboard becomes a built-in feature in Windows insider preview build 16215

emoji keyboard

@patricknelson
Copy link
Contributor

Interesting. Looks like there could still be an advantage of using mojibar: ability to use text search to filter down to the emoji you're interested in using. One feature they have that we do not is the ability to select a skin tone, however.

@yzhang-gh
Copy link

Lol 😂

@ZeeCoder
Copy link

I'd probably still go with mojibar.
I like consistency across devices. :)

@1j01
Copy link

1j01 commented Sep 24, 2017

They added search. 🔎
It's cool, you just open it and type ⌨ to search, but it's a little buggy. If I type something and backspace it, and type again, the text doesn't show up, and if I then select an emoji, it doesn't insert it. 🐛
Edit: (sent feedback so hopefully they can fix it 📢)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

9 participants