-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable Sonos support in mkchromecast #467
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sonos support was implicitly disabled as part of the refactor in 40b3773 , because the way it was initially added harmed code readability, modularity, correctness, etc.
For anyone wanting Sonos support, you can use the
stable
branch, or check out a version of the codebase prior to that change.The solution here is to finish refactoring
cast.py
(which has its own issues, even regarding Sonos), and then to re-incorporate Sonos support in a way that is sustainable for the codebase.The text was updated successfully, but these errors were encountered: