Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htc: parse htc-fmt,mdss-dsi-on-command, htc-fmt,mdss-dsi-off-command #43

Open
valerierx opened this issue Apr 22, 2024 · 3 comments
Open

Comments

@valerierx
Copy link

valerierx commented Apr 22, 2024

On HTC platforms that use Qualcomm SoCs, mdss_dsi_parse_dcs_cmds is not used to parse the panels init sequence, which is defined with htc-fmt,mdss-dsi-on-command, htc-fmt,mdss-dsi-off-command and htc-fmt,display-on-cmds. Replacing htc-fmt with qcom does not work and causes the following error:

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/valerie/Git/linux-mdss-dsi-panel-driver-generator/./lmdpdg.py", line 77, in <module>
    panel = Panel.parse(fdt, offset)
            ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/valerie/Git/linux-mdss-dsi-panel-driver-generator/panel.py", line 334, in parse
    return name and Panel(name.as_str(), fdt, node)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/valerie/Git/linux-mdss-dsi-panel-driver-generator/panel.py", line 273, in __init__
    'on': CommandSequence(fdt, mode_node, 'on'),
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/valerie/Git/linux-mdss-dsi-panel-driver-generator/panel.py", line 166, in __init__
    payload = bytes(next(itr) for _ in range(0, dlen))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: generator raised StopIteration

Here are the properties called: https://github.com/rom4nik/kernel_release-a51ul-3.10.28-g1e0287c/blob/master/drivers/video/msm/mdss/mdss_dsi_panel.c#L1259

Here are the properties parsed: https://github.com/rom4nik/kernel_release-a51ul-3.10.28-g1e0287c/blob/master/drivers/video/msm/mdss/mdss_htc_util.c#L195

And here is the downstream panel DTSI: https://github.com/rom4nik/kernel_release-a51ul-3.10.28-g1e0287c/blob/master/arch/arm/boot/dts/qcom/dsi-panel-a51.dtsi

@valerierx valerierx changed the title htc: replicate htc_mdss_dsi_parse_dcs_cmds htc: parse htc-fmt,mdss-dsi-on-command, htc-fmt,mdss-dsi-off-command Apr 22, 2024
@z3ntu
Copy link
Contributor

z3ntu commented Apr 23, 2024

Better link this function here https://github.com/rom4nik/kernel_release-a51ul-3.10.28-g1e0287c/blob/b3d118eff02b0a30c930bbf2a3e09e05ee5ac266/drivers/video/msm/mdss/mdss_htc_util.c#L195 ? Since this is where the property actually gets parsed by downstream.

@valerierx
Copy link
Author

Better link this function here https://github.com/rom4nik/kernel_release-a51ul-3.10.28-g1e0287c/blob/b3d118eff02b0a30c930bbf2a3e09e05ee5ac266/drivers/video/msm/mdss/mdss_htc_util.c#L195 ? Since this is where the property actually gets parsed by downstream.

You're right, forgot to include it.

@MarijnS95
Copy link
Contributor

I think this is a perfect candidate to add to #36?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants