-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: generate panel orientation code #24
Labels
help wanted
Extra attention is needed
Comments
Contributions welcome, should be pretty straightforward to add this. Although maybe we should wait until that TODO in the panel driver can be removed. |
Ack, perhaps I'll send a PR later if I'm not too busy or forget about this. Let's keep an eye on https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/panel/panel-simple.c commit-wise / around the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In case e.g.
qcom,mdss-dsi-panel-orientation = "180";
is set for a panel it should generate code for the panel driver to be able to customize the orientation in DTS (and provide the value to set there as well in the example).On my OnePlus 5 the used
qcom,mdss_dsi_samsung_s6e3fa5_1080p_cmd
panel is oriented physically upside down and thus the default rendered output is upside down if this isn't accounted for in the panel driver.FDT: cheeseburger.dtb.zip
Source DTS: https://github.com/LineageOS/android_kernel_oneplus_msm8998/blob/lineage-19.1/arch/arm/boot/dts/qcom/dsi-panel-samsung_s6e3fa5_1080p_cmd.dtsi#L158
For now I've got these related commits in my mainline kernel fork for the panel driver:
drm/panel: s6e3fa5: Read panel orientation
drm/panel: samsung-s6e3fa5: Implement .get_orientation callback
The text was updated successfully, but these errors were encountered: