Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in memory option would be nice #6

Open
BasHamer opened this issue Oct 2, 2018 · 3 comments
Open

An in memory option would be nice #6

BasHamer opened this issue Oct 2, 2018 · 3 comments

Comments

@BasHamer
Copy link

BasHamer commented Oct 2, 2018

the part of my code that picks the file names is a bit separated from where I create the files, it would be nice if I could use the library in memory w/o file I/O

@mrousavy
Copy link
Owner

mrousavy commented Oct 3, 2018

You could create a pull request for that if you want. Otherwise, I could look into that sometimes next week or so.

@BasHamer
Copy link
Author

BasHamer commented Oct 3, 2018

If a clean way comes to mind I'll take a look at it; as it stands the constructor has the file IO build into it for the AnimatedGifCreator and the IDisposable triggers the file write. It seems clunky to put it in there, as this really could be a factory method that is configured w/ defaults and then sits there waiting for files; leaving the original creator as a wrapper on top of it that handles file IO.

Not a small change, plus a breaking change if you want to name things what they are.

@mrousavy
Copy link
Owner

mrousavy commented Oct 8, 2018

I could redesign the library if there is enough interest, then an in memory option wouldn't be that much more work, as I'll be using the Stream abstract base class. See the redesign project for more info.
Help is greatly appreciated 😉👍

@mrousavy mrousavy added this to Done in Redesign Oct 8, 2018
@mrousavy mrousavy moved this from Done to To Do in Redesign Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants