New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor IFC support #28098
Comments
As a first step, I suggest to remove the IFC related code in Since @agviegas I'm not sure about the current state but does Regarding the roadmap, |
Sure - #28108. All makes sense, thanks! |
Description
Per the discussion in #25057 and the implementation in #25440,
IFCLoader
was removed from addons. The editor still dynamically imports it fromjsm/examples/loaders
, where it obviously no longer exists, meaning the editor fails to load IFC models. (Link to editor import ofIFCLoader.js
)I tried starting a PR to update the import maps for the editor as per the changes to the IFC example in #25440, which results in imports working on the first page reload after clearing my cache, but seems to result in a number of failed requests for
web-ifc-mt.worker.js
when trying to import after a second reload. I think this is potentially related toeditor/sw.js
, but I can't quite pin it down (sorry).I imagine it'd be equally valid to remove IFC support from the editor, as it doesn't make use of any other external loaders, but this might be a bit of a shame.
Apologies for this slightly off-topic aside:
I found getting to the bottom of this was a bit difficult, I think due to the deprecation of
web-ifc-three
mentioned in #27467. This means that most of the documentation links on https://github.com/ThatOpen/web-ifc-three are 404s at the moment, so trying to dig into where this request forweb-ifc-mt.worker.js
originated from, and whether there was a way to avoid it, was a bit more challenging than it might've been. Is there still a plan to migrate the example (and potentially the editor) to https://github.com/ThatOpen/engine_components? I think it's a bit of a challenge to make use of the current example code given the temporarily missing docs.Reproduction steps
The text was updated successfully, but these errors were encountered: