Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CodeMirror with Microsoft Monaco #35

Open
David-Carty opened this issue Apr 29, 2021 · 3 comments
Open

Replace CodeMirror with Microsoft Monaco #35

David-Carty opened this issue Apr 29, 2021 · 3 comments

Comments

@David-Carty
Copy link

David-Carty commented Apr 29, 2021

Please delete.

@mrdoob
Copy link
Owner

mrdoob commented May 4, 2021

Sorry, I was on holidays last week.

@mrdoob mrdoob changed the title Editor Replace CodeMirror with Microsoft Monaco May 4, 2021
@mrdoob
Copy link
Owner

mrdoob commented May 4, 2021

Original request:

Frames.js looks absolutely bursting at the seams with potential.
But CodeMirror, really?
I was a huge advocate of CodeMirror when my Grandfather was still working the fields, then Monaco Editor came along.
No need for TypeScript.
The NPM exposes the runtimes and they can be just dropped in, just like CodeMirror.
But you're the boss, for sure.

@David-Carty
Copy link
Author

Initially, I did not realise when frame.js was written, clearly, CodeMirror was the best choice at the time. It now seems trivial to have even raised this issue. Feel free to close. D.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants