Occasional segfaults and spotted some buffer overflows #4
Comments
mpentler
added
bug
|
Installed cppcheck and found some realloc errors. For example: Checking src/net.cpp ... Currently reading up on how to fix these with my limited C++ knowledge. |
|
Well, net.cpp now fixed. But others are proving a bit trickier. |
|
For the segfaults I’m getting they are constantly reproducible for me when switching between hosts: Thread 5 "boinctui" received signal SIGSEGV, Segmentation fault. Seems it’s when parsing results from querying a host. But figuring it out is beyond me right now. |
|
This doesn’t seem right. Changing host during parsing of data from the remote host seems to screw the process up. Ideally the process would be cancelled and the next host would be contacted. Here’s some gdb output: gdb-peda$ print curitem |
Two things that kind of belong together. A quick code review by a friend picked up an immediately obvious potential buffer overflow in one file. Also I’ve had a few segfaults when switching between added hosts in the host list. No idea what caused them but I can get gdb on the case when I get time.
Realistically the entire codebase needs a through going over to make sure there’s nothing obviously dodgy in there.
The text was updated successfully, but these errors were encountered: