Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

printf_("%.1e", 9.96) prints "10.0e+00", should print "1.0e+01" #120

Open
eyalroz opened this issue Aug 3, 2021 · 0 comments
Open

printf_("%.1e", 9.96) prints "10.0e+00", should print "1.0e+01" #120

eyalroz opened this issue Aug 3, 2021 · 0 comments

Comments

@eyalroz
Copy link

eyalroz commented Aug 3, 2021 •
edited

(migrated from eyalroz#24):

When we

printf_("%.3e", 9.96)

the rounding to 1 decimal precision digit makes the value 10.0, which should print as 1.0e+01 in exponent format. Unfortunately, library do not make sure and "re-normalize" the result of rounding, and produces 10.0e+00 instead.
eyalroz referenced this issue in eyalroz/printf Aug 4, 2021
@eyalroz
Added a testcase check exposing issue #120 - and corrected the expect…
7a9953e 
…ed output in two other testcase, which was indeed what the library was producing, but is invalid ("%e" output with a two-digit integral part).
eyalroz added a commit to eyalroz/printf that referenced this issue Aug 4, 2021
@eyalroz
Fixes mpaland#120 : When printing am "%f" form within an "%e" printin…
d87b19c 
…g, we now check whether the rounding of the fractional part according to the precision limits breaks the "%e" constraint of a single-digit integral part.
eyalroz added a commit to eyalroz/printf that referenced this issue Aug 4, 2021
@eyalroz
Added a testcase check exposing issue mpaland#120 (which is #24) - an…
610e338 
…d corrected the expected output in two other testcase, which was indeed what the library was producing, but is invalid ("%e" output with a two-digit integral part).
eyalroz added a commit to eyalroz/printf that referenced this issue Aug 4, 2021
@eyalroz
Fixes mpaland#120 (and thus fixes #24): When printing am "%f" form wi…
89e5c9b 
…thin an "%e" printing, we now check whether the rounding of the fractional part according to the precision limits breaks the "%e" constraint of a single-digit integral part.
eyalroz added a commit to eyalroz/printf that referenced this issue Aug 4, 2021
@eyalroz
Fixes mpaland#120 (and thus fixes #24): When printing am "%f" form wi…
42aa0e2 
…thin an "%e" printing, we now check whether the rounding of the fractional part according to the precision limits breaks the "%e" constraint of a single-digit integral part.
eyalroz added a commit to eyalroz/printf that referenced this issue Aug 5, 2021
@eyalroz
Fixes mpaland#120 (and thus fixes #24): When printing am "%f" form wi…
b027594 
…thin an "%e" printing, we now check whether the rounding of the fractional part according to the precision limits breaks the "%e" constraint of a single-digit integral part.
eyalroz added a commit to eyalroz/printf that referenced this issue Aug 5, 2021
@eyalroz
Fixes mpaland#120 (and thus fixes #24): When printing am "%f" form wi…
beaa7dd 
…thin an "%e" printing, we now check whether the rounding of the fractional part according to the precision limits breaks the "%e" constraint of a single-digit integral part.
eyalroz added a commit to eyalroz/printf that referenced this issue Aug 6, 2021
@eyalroz
Fixes mpaland#120 (and thus fixes #24): When printing am "%f" form wi…
96db5d1 
…thin an "%e" printing, we now check whether the rounding of the fractional part according to the precision limits breaks the "%e" constraint of a single-digit integral part.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz