Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On 16-bit-integer platforms, we overflow the integer part of 32-bit float's #108

Open
eyalroz opened this issue Jul 1, 2021 · 0 comments

Comments

@eyalroz
Copy link

eyalroz commented Jul 1, 2021

This issue is reported in Stuart Gorman's PR #77 :

We currently use a native int to store the integral part of a floating-point value to be printed in regular notation. This only works if the PRINTF_MAX_FLOAT value - at which we switch to scientific notation, is small enough to fit in a native int. Well, 1e9, the current default, is too big when the native integer type is 16 bit wide.

The cutoff point must fit inside the type we use to store the value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant