Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should git-cinnabar be included into firefox development overlay? #276

Open
kvark opened this issue Nov 16, 2021 · 2 comments
Open

Should git-cinnabar be included into firefox development overlay? #276

kvark opened this issue Nov 16, 2021 · 2 comments
Labels

Comments

@kvark
Copy link
Contributor

kvark commented Nov 16, 2021

git cinnabar is required by ./mach try commands, so I'd argue that it should be included by default.

@kvark kvark added the question label Nov 16, 2021
@kvark
Copy link
Contributor Author

kvark commented Nov 16, 2021

Also, less is expected by default by git, so we should include that.

@nbp
Copy link
Collaborator

nbp commented Nov 17, 2021

I am open to both, the problem I see with this approach is that mach might try to be clever based on programs which are installed, such as downloading the source code or using a tool even if it does not match the fetched source.

What I used to do is to start a nix-shell without the --pure argument, to use the tool which is provided in the environment.

Either sounds fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants