Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Add before/after ordering to components #436

Open
eigood opened this issue Sep 4, 2020 · 1 comment · May be fixed by #437
Open

New Feature: Add before/after ordering to components #436

eigood opened this issue Sep 4, 2020 · 1 comment · May be fixed by #437

Comments

@eigood
Copy link
Contributor

eigood commented Sep 4, 2020

Sometimes when loading components from a filesystem, the order is inconsistent, and can be random. It would be nice to have a way for extensions to insert themselves before an existing component, or after some other one, but while not actually needed to depend on the other.

There is a pull request for this, sending that shortly.

@eigood eigood linked a pull request Sep 4, 2020 that will close this issue
@jonesde
Copy link
Member

jonesde commented Sep 4, 2020

Could you describe the scenario you ran into where depends-on was not adequate and the before & after options helped?

This may be a result of my limited imagination but I'm having a hard time seeing where this is useful, and justifies the additional complexity. By complexity I don't mean the code so much, we can deal with that, but when configuring components the semantics of how depends-on, before, and after work together is messy. There are many possible 'invalid' permutations, like A depends-on B so would be after in the component order but B is set to be after A. With potential loops among multiple components it becomes even more complex, or rather there are even more invalid configuration scenarios (or perhaps valid depending on semantics yet to be defined). In general what should happen with those?

My preference would be to avoid those issues altogether by keeping this more simple, hence the initial question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants