Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Edge Case: Node Workers, --title #891

Closed
shellscape opened this issue Jun 5, 2023 · 5 comments
Closed

[bug] Edge Case: Node Workers, --title #891

shellscape opened this issue Jun 5, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@shellscape
Copy link

Describe the bug

Super edge case I just ran into using the ava package and command: ava in a task:

[DEBUG 13:38:55] moon_process::command_inspector  Running command node --title svc-test:test ../../node_modules/ava/entrypoints/cli.mjs  env_vars={"MOON_PROJECT_SOURCE": "services/svc-test", "MOON_CACHE_DIR": "/Users/user/code/test/.moon/cache", "MOON_TARGET": "svc-test:test", "MOON_PROJECT_RUNFILE": "/Users/user/code/test/.moon/cache/states/svc-test/runfile.json", "MOON_PROJECT_ID": "svc-test", "MOON_WORKSPACE_ROOT": "/Users/user/code/test", "MOON_PROJECT_ROOT": "/Users/user/code/test/services/svc-test", "MOON_TOOLCHAIN_DIR": "/Users/user/.proto", "MOON_WORKING_DIR": "/Users/user/code/test/services/svc-test"} working_dir=/Users/user/code/test/services/svc-test
  ⚠ Using configuration from /Users/user/code/test/ava.config.js
{ input: [] }

✘ Internal error
Error [ERR_WORKER_INVALID_EXEC_ARGV]: Initiated Worker with invalid execArgv flags: --title
Error [ERR_WORKER_INVALID_EXEC_ARGV]: Initiated Worker with invalid execArgv flags: --title


This is related to the use of workers in Ava (and Vitest among others). 

**Steps to reproduce**

We can put together a reproduction if needed.

**Expected behavior**

Not sure, but it would be cool if there was a way to disable the use of the `--title` flag for constructed node calls.

**Screenshots**

n/a

**Environment**

<!-- Run `npx envinfo` and paste it below. This requires Node.js to be installed. -->

Moon 1.7.1
MacOS Ventura


**Additional context**

<!-- Add any other context about the problem here. -->
@shellscape shellscape added the bug Something isn't working label Jun 5, 2023
@milesj
Copy link
Collaborator

milesj commented Jun 5, 2023

This is weird, is ava trying to read the args from the parent node process??

@shellscape
Copy link
Author

Crap I thought I had pasted the related issues:

avajs/ava#3207
nodejs/node#41103 (comment)

it looks like possibly a bug with Node, and something that Ava should account for. likelihood that either gets resolved in a timely manner is slim.

@milesj
Copy link
Collaborator

milesj commented Jun 5, 2023

Yikes. I can probably remove the title for now. I'm not sure anyone actually cares about it... lol.

@milesj
Copy link
Collaborator

milesj commented Jun 5, 2023

1.7.2

@milesj milesj closed this as completed Jun 5, 2023
@shellscape
Copy link
Author

much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants