-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLVM.lua does not get VS version from build.sh ("Error finding an LLVM build") #1831
Comments
Can you send a PR? |
cmcneish
added a commit
to cmcneish/CppSharp
that referenced
this issue
Feb 19, 2024
Pass through Visual Studio version from build.sh into build/LLVM.lua, so that the downloaded version is consistent with build.sh's view rather than the host command prompt's view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Brief Description
build/llvm/LLVM.lua detects the VS version from either cl.exe or msbuild.exe, but build/build.sh specifies (currently)
vs=vs2022
.If build.sh is run from a VS developer command prompt corresponding to a different version then
generate()
will fail the following way:OS: Windows / OS X / Linux (include version and/or distro)
Used headers
N/A
Used settings
Target: MSVC/GCC/Clang
Other settings:
Stack trace or incompilable generated code
N/A
Sample fix (I didn't check if other uses of premake.sh need --vs as well):
The text was updated successfully, but these errors were encountered: