Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution entity #20

Open
larrybabb opened this issue Aug 28, 2017 · 3 comments
Open

Contribution entity #20

larrybabb opened this issue Aug 28, 2017 · 3 comments

Comments

@larrybabb
Copy link

Will there be a primary Contribution entity added to the model (in the diagrams on the home page of the wiki, for instance)?

In the ClinGen model we discussed using the Contribution concept to capture the provenance information for Statements.

Can you clarify the plans for including this as a first class concept in the SEPIO model and if not, why?

@larrybabb
Copy link
Author

Sorry just saw this is a duplicate of #10. However, the issue I am trying to focus on is how the ClinGen Contribution approach maps (or doesn't map) to the SEPIO approach.

For example, In the SEPIO model, I believe that "asserted_by(Agent)", "date_asserted(Datetime)", "Activity" and "Publication" all possibly contribute to the Provenance of a Statement, whether it be an Assertion or a Study Finding.

In the Contribution model we are capturing the Agent, Role and Date. I think the Contribution.agent and Contribution.date are roughly the same as the "asserted_by" and "date_asserted".

How can we clarify the mapping and harmonization more clearly for the remaining differences? role, activity, publication?

@mbrush
Copy link
Member

mbrush commented Aug 31, 2017

@larrybabb - mappings for all attributes are specified in the mapping spreadsheet. However, role, activity,and publication attributes are not included there. If you intend to include these as attributes of Contributions, can you add them to the mapping spreadsheet (and describe them in column C). Then we can discuss and document decisions there. Thanks!

@larrybabb
Copy link
Author

larrybabb commented Aug 31, 2017

We do have role already defined within Contribution see A08 Contribution.role on the attributes mapping sheet. We do not have Activity and/or Publication in our model, but we should discuss this with the team.

I think my main concern is that SEPIO appears to be placing the set of provenance attributes on some classes directly vs. organizing them in a separate class called Contribution. I am wondering if Contribution is something slightly different than things like the Assertion "asserted_by"/"validated_by" and the EvidenceLine "assessed_by" and Activity "has_agent" kind of attributes.

We can discuss today to see if there's work to be done related to this or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants