-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting plan interval #222
Comments
Hi @PabloHendriks, thank you for your contribution to the codebase. Before I merge your PR I want to make sure that there isn't another way for your specific use case. What exactly is your use case? What does your |
Hi @Naoray, Thank you very much for your quick reply. Yes, I could use the config to access the interval, though it would be nice to way of accessing the interval from the object itself. I believe that a more 'dynamic' way of accessing it would be more interesting. Let me know what you think! |
Hi @PabloHendriks, I am not entirely convinced yet, but we're keeping this open for review for the next major release. |
Hi,
My problem is about getting the plan interval. When looking at the DefaultIntervalGenerator, the interval is a protected attribute and there is only a
isMonthly()
method which would not make distinctions between a monthly subscription or a 3-month subscription. Same thing with a yearly or 2 yearly subscription.Thanks in advance.
The text was updated successfully, but these errors were encountered: