-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow __splink__df_concat
to be computed without linker
#2142
Labels
Comments
We want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We plan to allow the user to do some forms of exploratory analysis without needing to create a linker (like
profile_columns
and various types of blocking analysis e.g. #2136 )But this means that
__splink__df_concat
needs to be computed without the linker.At the moment, this requires a lot of code that's confusing to read and will be repetitive:
splink/splink/profile_data.py
Lines 237 to 267 in 66ec54f
Issue can be addressed by removing the need for a
linker
to compute__splink__df_concat
, giving us reusable code that can be used forprofile_columns
, blocking analysis etc.The text was updated successfully, but these errors were encountered: