New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: df.query and df.eval harcode level #4478
Labels
Code Quality 💯
Improvements or issues to improve quality of codebase
P2
Minor bugs or low-priority feature requests
Comments
mvashishtha
added
the
Code Quality 💯
Improvements or issues to improve quality of codebase
label
May 27, 2022
mvashishtha
pushed a commit
to mvashishtha/modin
that referenced
this issue
Jun 6, 2022
Signed-off-by: mvashishtha <[email protected]>
8 tasks
mvashishtha
changed the title
Remove hardcoding of local and global scopes for df.query and df.eval
BUG: df.query and df.eval harcode level
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Code Quality 💯
Improvements or issues to improve quality of codebase
P2
Minor bugs or low-priority feature requests
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. What kind of performance improvements would you like to see with this new API?
For the pandas API functions
df.query
anddf.eval
, Modin hardcodes the function depth for local and global variable scopes. This is done inmodin/pandas/dataframe.py
in the_update_var_dicts_in_kwargs
function:Instead of this approach, Modin should support the
levels
parameter inpandas.eval
(called bydf.query
anddf.eval
): https://pandas.pydata.org/docs/reference/api/pandas.eval.html#pandas.eval to create the local and global scopes.The text was updated successfully, but these errors were encountered: