Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search feature #3319

Open
ctonylee opened this issue Jan 4, 2022 · 1 comment
Open

Search feature #3319

ctonylee opened this issue Jan 4, 2022 · 1 comment

Comments

@ctonylee
Copy link

ctonylee commented Jan 4, 2022

What happened?

  • Minimal Mistakes version: 4.24.0
  • Ruby gem or remote theme version: default theme
  • Jekyll version:
  • Git repository URL: used https://github.com/mmistakes/mm-github-pages-starter
  • Hosted on GitHub Pages (if yes provide URL to site):
  • Operating system: MAC 12.1 Monterey

Expected behavior

Scenario, when using minimal-mistake for foreign language, for special terms, I will add English keywords beside the translation. For example of of the following term 看板 in Chinese, I've added the English term "Kanban" beside the translation.

看板 (Kanban)

Expected behavior: Can search the term "Kanban" when the content includes "(Kanban)" which is wrapped by brackets.

Actual behavior: Search the term "Kanban" returns nothing.

Steps to reproduce the behavior

Steps

  1. Clone https://github.com/mmistakes/mm-github-pages-starter and start the server by bundle exec jekyll serve
  2. Add the following text into any post
aaaa (Kanban) bbbb
cccc (Apple Pie) dddd
  1. Search for Kanban returns nothing
  2. Search for Appl returns the page, but Apple returns nothing

image

image

image

Other

No response

@ultimape
Copy link
Contributor

ultimape commented Jul 5, 2022

I may be running into a similar problem with lunr.

What search engine do you have configured in your _config.xml?
Here's what mine looks like:

# Search Settings
search_provider: lunr
search_full_content: true # by default Lunr only does 50 words
lunr:
  search_within_pages: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants