Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

negotiationMandatory behavior does not match documentation. #237

Open
douglampe opened this issue Nov 5, 2023 · 3 comments
Open

negotiationMandatory behavior does not match documentation. #237

douglampe opened this issue Nov 5, 2023 · 3 comments

Comments

@douglampe
Copy link

Per the documentation:

negotiationMandatory: Disable telnet negotiations if needed. Can be used with 'send' when telnet specification is not needed. Telnet client will then basically act like a simple TCP client. Defaults to true.

It appears negotiationMandatory has no impact on send. Since send is basically a passthrough to write, the only checks after sending are for waitFor and sendTimeout. The desired effect of negotiationMandatory: false seems to be achieved by sendTimeout: undefined. However, since sendTimeout defaults to 2000, this is not an obvious option since undefined must be explicitly set.

I believe a better check would be to check for if (this.opts.sendTimeout && negotiationMandatory) unless I am misunderstanding the intent of negotiationMandatory.

@antfurn
Copy link

antfurn commented Feb 10, 2024

Hi, I've just hit this same issue. I'm guessing this is a recent(ish) change as I've not had this problem with older version.

Thanks, Antony

@mkozjak
Copy link
Owner

mkozjak commented Feb 11, 2024

@antfurn able to pinpoint on what version it worked last?

@antfurn
Copy link

antfurn commented Feb 11, 2024

Pretty sure I was not seeing this issue with v2.0.9
The other version I was using before that was v2.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants