New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
negotiationMandatory behavior does not match documentation. #237
Comments
Hi, I've just hit this same issue. I'm guessing this is a recent(ish) change as I've not had this problem with older version. Thanks, Antony |
@antfurn able to pinpoint on what version it worked last? |
Pretty sure I was not seeing this issue with v2.0.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per the documentation:
It appears
negotiationMandatory
has no impact on send. Sincesend
is basically a passthrough towrite
, the only checks after sending are forwaitFor
andsendTimeout
. The desired effect ofnegotiationMandatory: false
seems to be achieved bysendTimeout: undefined
. However, sincesendTimeout
defaults to2000
, this is not an obvious option sinceundefined
must be explicitly set.I believe a better check would be to check for
if (this.opts.sendTimeout && negotiationMandatory)
unless I am misunderstanding the intent ofnegotiationMandatory
.The text was updated successfully, but these errors were encountered: