Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow forms with fewer fields #126

Open
shkarlsson opened this issue Jan 31, 2024 · 1 comment
Open

Allow forms with fewer fields #126

shkarlsson opened this issue Jan 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@shkarlsson
Copy link

I suggest allowing for fewer fields in the form. Right now, it seems like all fields are shown, even if a dict with fewer fields is passed as fields to Authenticate.register_user. Furthermore, to allow for Username to be optional, I suggest indexing on Email (which should always be present) instead of Username.

Is this a good idea? Could this be merged if I worked on it?

I see a few places in authenticate.py where the index would need to be replaced with email and some adjusted logic to only show and save what the function parameters call for (and not every field). Is there anything else that would make this more challenging?

@mkhorasani mkhorasani added the enhancement New feature or request label Jan 31, 2024
@mkhorasani
Copy link
Owner

Hi @shkarlsson, thank you for reaching out. I am definitely open to the idea of indexing by email as opposed to username as an option. I will attempt to address this in a future release and will keep you posted. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants