-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename normalize
to subscale_by
#223
Comments
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per discussion here: #219 (comment)
I think something like
subscale_by
would be more descriptive and would be more consistent with the newsubscale
andsubguide
params.subscale_by
with options:NULL
orcharacter()
<=>normalize = "all"
"panels"
(or maybe"panel"
) <=>normalize = "panels"
"xy"
<=>normalize = "xy"
"groups"
(or maybe"group"
) <=>normalize = "groups"
normalize
slab_type
(keep an internal copy of the old param to detect use)normalize = "none"
point them tosubscale = "identity"
insteadnormalize = "all"
point them tosubscale_by = NULL
insteadsubscale_by = ...
The text was updated successfully, but these errors were encountered: