Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting image title #206

Open
jloewe opened this issue Mar 15, 2024 · 2 comments
Open

Support setting image title #206

jloewe opened this issue Mar 15, 2024 · 2 comments
Labels
feature-request New feature or request

Comments

@jloewe
Copy link

jloewe commented Mar 15, 2024

Is your feature request related to a problem? Please describe.
When you open carbon, you can specify an image title which is included in the screenshot (have a look at the example).

Example
Carbon URL

Describe the solution you’d like:

  • automatically set the title when a file is used
  • flag to manually specify the title

Describe alternatives you’ve considered:

  • leaving the title out, which is not favorable when you have multiple screenshots next to each other

Additional context:
You can specify the image title using the tb query parameter.

@jloewe jloewe added the feature-request New feature or request label Mar 15, 2024
@mixn
Copy link
Owner

mixn commented Mar 28, 2024

Hey @jloewe, thanks for opening! :) I wasn’t aware this was a thing. I’ll try to make some time and add it asap, since it’s just another param, shouldn’t be too much work.

@jloewe
Copy link
Author

jloewe commented Mar 28, 2024

Hey @jloewe, thanks for opening! :) I wasn’t aware this was a thing. I’ll try to make some time and add it asap, since it’s just another param, shouldn’t be too much work.

Thank you in advance! Take your time. I took a look at it, but I'm not sure if I could submit a qualified PR.
It looks like part of your module api would have to be changed (Prompt.getFile would need to return the file and the name if it is specified, or another getter for the file name could be added).
If you want, I can try to implement this, but I'm not sure if I would match your preferred style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants