-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fact_store's lifecycle? #2971
Labels
Comments
It looks like an oversight to me. |
Thanks for your answer.
|
(And while you're there, any idea on whether #2930 is a mistake on my end or indeed a bug of the same kind?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm still trying to figure out #2930, and I noticed that every fact I ever created, directly through a Fact Source, or indirectly through a link's parser, is stored in
fact_store
(after some tests, only the facts that have been "loaded", e.g. through an operation, are in this case).Even though 99% of the "sources" of these facts, i.e. either operations or Fact Sources, have been deleted since.
I see no call to
_delete_fact
frombase_knowledge_svc.py
, so it makes sense that they remain, but I would expect these facts to disappear when their source disappears, e.g. when I delete a Fact Source or an operation.Is this a desired behavior, or an oversight? If this is desired, what are the reasons for it?
The text was updated successfully, but these errors were encountered: