New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONNECT request triggers response
hook
#6632
Labels
Comments
Where should the test be added? |
https://github.com/mitmproxy/mitmproxy/blob/main/test/mitmproxy/proxy/layers/http/test_http.py
would be a good fit.
…On Thu, Feb 1, 2024, 11:24 Ha Anh Vu ***@***.***> wrote:
Where should the test be added?
—
Reply to this email directly, view it on GitHub
<#6632 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHY2PURIJAHMFTDRUL4GLLYRNUPFAVCNFSM6AAAAABCT3POE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRQHE4TCMZVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#6599 (comment) has a repro. This line here makes us trigger the
response
hook for failed flows, which we don't want to do:mitmproxy/mitmproxy/proxy/layers/http/__init__.py
Line 760 in c49c38e
The correct fix here is probably not to call
send_response
here but mirror what we do for the happy path. And then this needs a test.The text was updated successfully, but these errors were encountered: