This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Fix duplicate '/' in fspfs_lookup & fspfs_create_directory #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 1.0.0, FS path normalization doesn't remove extraneous slash and this lead to a 0x202 error code.
misson20000
suggested changes
Jun 24, 2019
There was a problem hiding this comment.
Looks like fspfs_create_file needs to be fixed too, right? Perhaps this would be better off being split into a static path_concat function, but I also wonder why this is necessary in the first place- where are these extraneous slashes coming from and is there a better place to sanitize them?
|
|
||
| int extra_slash = 0; | ||
| if (base_path_len == 0 || new_inode->path[base_path_len - 1] != '/') { | ||
| new_inode->path[base_path_len] = '/'; |
There was a problem hiding this comment.
base_path_len++ and remove extra_slash variable?
| if (base_path_len == 0 || full_path[base_path_len - 1] != '/') { | ||
| full_path[base_path_len] = '/'; | ||
| extra_slash = 1; | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 1.0.0, FS path normalization doesn't remove extraneous slash and this
lead to a 0x202 error code.
This fix misson20000/twili#73