-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ping before release! randomise lease ip #77
Comments
Pinging is not feasible, that would cause a state explosion. Would have to somehow tell the caller to ping it, check if it's ok and then install the lease. Can be done without touching the library. The addresses are not given based on a linear search. A ridiculously naive hashing of the mac address is made, the rationale for this was to try to always give the same address to the same clients. But as we can see, that's kinda fucked up since we don't keep state. Randomizing and, in case of collision, doing a linear search should be enough. (sarcasm HIPSTERIZE ALL THE THINGS ! |
while deploying charrua in africa with no persistent leases, we discovered that a restart of charrua leads to it handing out ip addresses with active lease (from the previous incarnation). -- see also https://tools.ietf.org/html/rfc5227
ways to fix this include:
IMHO we should do both.
The text was updated successfully, but these errors were encountered: