Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MJML dependency #569

Open
ninsuo opened this issue Apr 10, 2021 · 0 comments
Open

Remove MJML dependency #569

ninsuo opened this issue Apr 10, 2021 · 0 comments
Labels
Administration Average It's not easy, it's not hard either Email Triggers Low Low priority to implement

Comments

@ninsuo
Copy link
Contributor

ninsuo commented Apr 10, 2021

Since Symfony 4.4, we can use a cool NotificationEmail object in order to send emails.
It's time to replace the ugly Mail service currently used.

Details:
https://symfony.com/blog/new-in-symfony-4-4-notification-emails

As it is stated in the doc, these notifications are intended to be sent to ourselves:

  • a non removable importance
  • only one action button
  • an useless "sent with symfony footer"

But it's still very inspiring:

  • it uses inky which works standalone so we won't need mjml dependency anymore
  • it adds support to markdown in email templates
@ninsuo ninsuo added Low Low priority to implement Average It's not easy, it's not hard either Administration Email Triggers labels Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration Average It's not easy, it's not hard either Email Triggers Low Low priority to implement
Projects
None yet
Development

No branches or pull requests

1 participant