Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change ttfb_distribution metrics to histogramMetric #17115

Merged
merged 1 commit into from May 3, 2023
Merged

change ttfb_distribution metrics to histogramMetric #17115

merged 1 commit into from May 3, 2023

Conversation

harshavardhana
Copy link
Member

Description

change ttfb_distribution metrics to histogramMetric

Motivation and Context

fixes #17060

How to test this PR?

As per #17060

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

shtripat
shtripat approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 9112ca4 into minio:master May 3, 2023
16 checks passed
@harshavardhana harshavardhana deleted the histogram branch May 3, 2023 14:31
@bh4t bh4t added the bugfix label May 22, 2023
harshavardhana added a commit that referenced this pull request Jul 7, 2023
@harshavardhana
Revert "change ttfb_distribution metrics to histogramMetric (#17115)"
abb1f22 
This reverts commit 9112ca4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klauspost klauspost klauspost approved these changes

@shtripat shtripat shtripat approved these changes

@vadmeste vadmeste Awaiting requested review from vadmeste

@poornas poornas Awaiting requested review from poornas

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong metric type for minio_s3_time_ttfb_seconds_distribution?
4 participants
@harshavardhana @klauspost @shtripat @bh4t