Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing possible parameters in client methods #1247

Open
d-michail opened this issue Nov 23, 2023 · 2 comments
Open

missing possible parameters in client methods #1247

d-michail opened this issue Nov 23, 2023 · 2 comments

Comments

@d-michail
Copy link

Hi,

I am experiencing a small issue with the minio client types. I am trying to call a few functions like getObject, listObjects and copyObject but the type definitions seem to be incomplete.

As an example I am using

client.getObject(bucket, uuId, { versionId: 'myversion' })

The underlying implementation supports the call, but the type does not, assuming that I always use a callback for the 3rd parameter. Am I missing something obvious here, or is it just a bug in the types definition? If it is, I can possibly send a PR.

@aldy505
Copy link
Contributor

aldy505 commented Nov 24, 2023

This is supposed to be typing's mistake. But I can see that it should be fixed on #1186

@prakashsvmx
Copy link
Member

prakashsvmx commented Nov 24, 2023

Please use the latest async await /promise style. The callback style is deprecated.
We are migrating to typescript, the migration is still in progress.

@d-michail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants