-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object is not traced when the request returns an error #1664
Comments
The error will be displayed at the end @agnivade - we only print when the "request" was actually sent and we did get a "Response" back. Currently, it's not implemented to print tracing for network errors. The main reason is we use Go's Let's see if we can add this to the trace. |
Thanks @harshavardhana
Yes, that is the problem here. Due to this, the user does not know exactly which requests are failing which makes things hard to debug. I'd suggest to log the request unconditionally, and then log the response with the same logic as you are doing now.
You just need to display the request using |
In this line
minio-go/api.go
Line 491 in ff482a1
I'd suggest to split the method into 2 parts: first logging the request unconditionally, then logging the response along with the condition of
&& resp.StatusCode == http.StatusOK
.Due to this, we are unable to debug connection failures from object storage: mattermost/mattermost#19584
The text was updated successfully, but these errors were encountered: