Can't reset TCLink to zero loss and delay #881

snizovtsev · 2019-05-30T21:43:15Z

This optimization prevents zeroing loss or delay link parameters after non-zero period because "not 0 = True" in Python:

Lines 352 to 354 in e203808

 if ( bw is None and not delay and not loss 

 and max_queue_size is None ): 

 return

It should be compared to None or running value instead.

cheriimoya · 2022-02-02T17:58:26Z

you are right

lantz · 2022-04-01T00:23:36Z

I believe the intent was to not add an unnecessary queuing discipline.

Is there a workaround if you set the loss to 0%?

janev94 · 2022-11-18T20:46:10Z

addLink currently by default makes loss to 0%. This is not an issue in the current build at least @lantz .

lantz · 2022-11-19T01:45:28Z

@cheriimoya
Is setting the loss to 0% a reasonable workaround?

cheriimoya added a commit to cheriimoya/mininet that referenced this issue Feb 2, 2022

Fix bug in if condition, see mininet#881

bdf530a

cheriimoya linked a pull request Feb 2, 2022 that will close this issue

Fix bug in if condition, see #881 #1110

Open

cheriimoya added a commit to cheriimoya/mininet that referenced this issue Apr 3, 2022

Fix bug in if condition, see mininet#881

5a29249

Provide feedback