Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session Cookie expires before CLEANUP_REMOVE_SESSIONS_DAYS #2214

Closed
Kioubit opened this issue Nov 25, 2023 · 0 comments · Fixed by #2622
Closed

Session Cookie expires before CLEANUP_REMOVE_SESSIONS_DAYS #2214

Kioubit opened this issue Nov 25, 2023 · 0 comments · Fixed by #2622
Labels
change proposal

Comments

@Kioubit
Copy link

Kioubit commented Nov 25, 2023

v2/internal/http/cookie/cookie.go

Line 28 in 32779f5

Expires: time.Now().Add(cookieDuration * 24 * time.Hour),

The session cookie has a static expiry time of 30 days. The expected behavior would be for the expiry time to be at least
as long as the CLEANUP_REMOVE_SESSIONS_DAYS configuration option specifies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change proposal
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make cookie duration dependent on configuration Kioubit/miniflux-v2
2 participants
@fguillot @Kioubit