Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/parser: do not clean entry tags in storage module #2563

Open
rdelaage opened this issue Mar 24, 2024 · 4 comments
Open

storage/parser: do not clean entry tags in storage module #2563

rdelaage opened this issue Mar 24, 2024 · 4 comments

Comments

@rdelaage
Copy link
Contributor

This is not really a bug, but en enhancement to improve code maintainability. Currently the cleaning of entry tags is done the storage module. This is not the relevant module. This should be done in the parser module. This would need a little refactoring.

@rdelaage
Copy link
Contributor Author

See #2556 (comment)

@rdelaage
Copy link
Contributor Author

@jvoisin introduced it in the RSS module with #2567. It should be done also for JSON and Atom feeds. I think we can factorize by putting it in the miniflux.app/v2/internal/reader/parser module, at the end of the ParseFeed function.

@jvoisin
Copy link
Contributor

jvoisin commented Mar 25, 2024

reader/json is already taking care of it, and so does reader/atom

@rdelaage
Copy link
Contributor Author

Oh didn't know, but we still need to factorize it, this avoid code duplication and if a new type of feed is added it ensure it follows Miniflux standards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants